Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cadence 1.0 migration #5353

Merged
merged 22 commits into from
Feb 12, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 5, 2024

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (50f8c81) 56.07% compared to head (0a0ceee) 56.37%.

Files Patch % Lines
...edger/migrations/change_contract_code_migration.go 62.79% 16 Missing ⚠️
...util/ledger/migrations/cadence_values_migration.go 76.19% 12 Missing and 3 partials ⚠️
...il/ledger/migrations/staged_contracts_migration.go 46.15% 14 Missing ⚠️
cmd/util/ledger/migrations/deploy_migration.go 85.71% 6 Missing and 3 partials ⚠️
...execution-state-extract/execution_state_extract.go 27.27% 8 Missing ⚠️
model/flow/ledger.go 0.00% 5 Missing ⚠️
.../util/ledger/migrations/account_based_migration.go 33.33% 1 Missing and 1 partial ⚠️
...md/util/ledger/util/migration_runtime_interface.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5353      +/-   ##
==========================================================
+ Coverage                   56.07%   56.37%   +0.29%     
==========================================================
  Files                        1024     1027       +3     
  Lines                       98984    99195     +211     
==========================================================
+ Hits                        55510    55918     +408     
+ Misses                      39345    39129     -216     
- Partials                     4129     4148      +19     
Flag Coverage Δ
unittests 56.37% <82.75%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent force-pushed the bastian/improve-migration branch from 5135859 to 05214f5 Compare February 8, 2024 05:47
@turbolent turbolent requested review from a team February 8, 2024 18:25
@turbolent turbolent marked this pull request as ready for review February 8, 2024 18:25
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one comment in the merge function

cmd/util/ledger/migrations/merge.go Outdated Show resolved Hide resolved
cmd/util/ledger/migrations/deploy_migration.go Outdated Show resolved Hide resolved
@turbolent turbolent changed the title Improve migration Improve Cadence 1.0 migration Feb 10, 2024
Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>
Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>
@turbolent turbolent merged commit 964ef5c into feature/stable-cadence Feb 12, 2024
51 checks passed
@turbolent turbolent deleted the bastian/improve-migration branch February 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants