[Access] Add state streaming API to observers #5368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-data' of github.com:AndriiDiachuk/flow-go into UlyanaAndrukhiv/4406-state-streaming-to-observer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5368 +/- ##
==========================================
- Coverage 55.82% 55.78% -0.05%
==========================================
Files 1031 1031
Lines 100860 100860
==========================================
- Hits 56302 56261 -41
- Misses 40229 40270 +41
Partials 4329 4329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Feb 29, 2024
There was a problem hiding this comment.
nothing really stands out. it will be much easier once #5256 is merged
…thub.com:UlyanaAndrukhiv/flow-go into UlyanaAndrukhiv/4406-state-streaming-to-observer
Guitarheroua
approved these changes
Mar 6, 2024
…thub.com:UlyanaAndrukhiv/flow-go into UlyanaAndrukhiv/4406-state-streaming-to-observer
|
@peterargue, ready for review cause #5256 was merged |
peterargue
approved these changes
Mar 12, 2024
peterargue
added a commit
that referenced
this pull request
Mar 15, 2024
…ate-streaming-to-observer [Access] Add state streaming API to observers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4406
This PR includes implementations the streaming API for observers. Updated integration test.
This branch was merged with #5256 as it needs some parts for the issue above.