Event-based test refactoring for GossipSub RPC inspection unit tests #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
approved these changes
Feb 13, 2024
yhassanzadeh13
approved these changes
Feb 23, 2024
| spamMsgFactory: func(spammerId peer.ID, _ peer.ID, topic channels.Topic) *pubsub_pb.Message { | ||
| return p2ptest.PubsubMessageFixture(t, p2ptest.WithFrom(spammerId), p2ptest.WithTopic(topic.String())) | ||
| }, | ||
| }, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5374 +/- ##
==========================================
+ Coverage 56.04% 59.51% +3.47%
==========================================
Files 1026 430 -596
Lines 100116 44706 -55410
==========================================
- Hits 56106 26605 -29501
+ Misses 39707 16181 -23526
+ Partials 4303 1920 -2383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small but significant improvement to the control message validation inspector unit tests by removing the use of time.Sleep and instead wait until
finished processing queued work itemfrom the internal inspection request worker pool queue effectively making the tests more reliable.