Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Add tests to assert that Flow EVM events can be properly CCF encoded/decoded #5384

Merged
merged 4 commits into from
Feb 17, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Feb 13, 2024

This will help to avoid errors when changing the type of the event fields.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07e3dab) 55.90% compared to head (f5d65d1) 55.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
+ Coverage   55.90%   55.99%   +0.09%     
==========================================
  Files        1024     1024              
  Lines       99160    99160              
==========================================
+ Hits        55434    55525      +91     
+ Misses      39488    39394      -94     
- Partials     4238     4241       +3     
Flag Coverage Δ
unittests 55.99% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-Peter m-Peter force-pushed the flow-evm-events-ccf-tests branch 2 times, most recently from 533571f to bef67ab Compare February 15, 2024 17:09
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fvm/evm/types/events_test.go Show resolved Hide resolved
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@franklywatson franklywatson added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@m-Peter m-Peter force-pushed the flow-evm-events-ccf-tests branch from e5e5bd1 to f5d65d1 Compare February 17, 2024 15:54
@franklywatson franklywatson added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@franklywatson franklywatson added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@franklywatson franklywatson added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@franklywatson franklywatson added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@franklywatson franklywatson added this pull request to the merge queue Feb 17, 2024
Merged via the queue into onflow:master with commit b579900 Feb 17, 2024
51 checks passed
@m-Peter m-Peter deleted the flow-evm-events-ccf-tests branch March 20, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants