-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Cadence 1.0 migration #5388
Improve Cadence 1.0 migration #5388
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5388 +/- ##
==========================================================
+ Coverage 56.37% 56.40% +0.02%
==========================================================
Files 1032 1032
Lines 100613 100711 +98
==========================================================
+ Hits 56721 56804 +83
- Misses 39587 39599 +12
- Partials 4305 4308 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…0-M7' into bastian/cadence-1-migration-fixes
systemContracts.ViewResolver.Address.HexWithPrefix(), | ||
metadataViewsAddress.HexWithPrefix(), | ||
burnerAddress.HexWithPrefix(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flow-ft's contract code "constructor function" changed in a recent commit: the argument is no longer the address of the view resolver, but the one of the burner
More improvements are needed, but that should not block getting these improvements in |
Work towards onflow/cadence#3096
Caused by onflow/flow-core-contracts@7204ba8#diff-1803784ae7aa05d34fc981d144045dba79bac0d9a866c1b0d8df69ef3e8bea85L105-R110
CadenceBaseMigrator.InitMigration
: Instead of building a full payload snapshot, which is only used to get contract code for any account, only gather all contract code registers and build a mapping for it