Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cadence 1.0 migration #5388

Merged
merged 23 commits into from
Feb 26, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 13, 2024

Work towards onflow/cadence#3096

@turbolent turbolent requested a review from SupunS February 13, 2024 22:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 58.05085% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 56.40%. Comparing base (0776bdc) to head (1bc3c79).

Files Patch % Lines
...md/util/ledger/util/migration_runtime_interface.go 0.00% 61 Missing ⚠️
...util/ledger/migrations/cadence_values_migration.go 48.33% 27 Missing and 4 partials ⚠️
...edger/migrations/change_contract_code_migration.go 91.02% 7 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5388      +/-   ##
==========================================================
+ Coverage                   56.37%   56.40%   +0.02%     
==========================================================
  Files                        1032     1032              
  Lines                      100613   100711      +98     
==========================================================
+ Hits                        56721    56804      +83     
- Misses                      39587    39599      +12     
- Partials                     4305     4308       +3     
Flag Coverage Δ
unittests 56.40% <58.05%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent changed the base branch from feature/stable-cadence to auto-update-onflow-cadence-v1.0.0-M7 February 14, 2024 19:15
…0-M7' into bastian/cadence-1-migration-fixes
Base automatically changed from auto-update-onflow-cadence-v1.0.0-M7 to feature/stable-cadence February 14, 2024 20:32
Comment on lines -318 to +350
systemContracts.ViewResolver.Address.HexWithPrefix(),
metadataViewsAddress.HexWithPrefix(),
burnerAddress.HexWithPrefix(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flow-ft's contract code "constructor function" changed in a recent commit: the argument is no longer the address of the view resolver, but the one of the burner

@turbolent turbolent marked this pull request as draft February 15, 2024 01:57
@turbolent turbolent marked this pull request as ready for review February 23, 2024 20:33
@turbolent
Copy link
Member Author

More improvements are needed, but that should not block getting these improvements in

@turbolent turbolent requested review from a team February 23, 2024 20:33
@turbolent turbolent merged commit b9c9109 into feature/stable-cadence Feb 26, 2024
50 of 51 checks passed
@turbolent turbolent deleted the bastian/cadence-1-migration-fixes branch February 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants