Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osusergo flag and missing previewnet case #5418

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

turbolent
Copy link
Member

No description provided.

@turbolent turbolent requested a review from a team February 20, 2024 19:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6b0ce48) 56.33% compared to head (cb40a41) 56.32%.

Files Patch % Lines
state/protocol/defaults.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5418      +/-   ##
==========================================================
- Coverage                   56.33%   56.32%   -0.01%     
==========================================================
  Files                        1023     1023              
  Lines                       99116    99116              
==========================================================
- Hits                        55834    55825       -9     
- Misses                      39063    39067       +4     
- Partials                     4219     4224       +5     
Flag Coverage Δ
unittests 56.32% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing force-pushed the leo-stable-cadence-util branch from 8e99715 to a1b2a39 Compare February 20, 2024 19:50
@@ -12,7 +12,7 @@ import (
// more details on this value.
func DefaultEpochCommitSafetyThreshold(chain flow.ChainID) (uint64, error) {
switch chain {
case flow.Mainnet, flow.Testnet, flow.Sandboxnet:
case flow.Mainnet, flow.Testnet, flow.Sandboxnet, flow.Previewnet:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbolent turbolent merged commit 4c430f7 into feature/stable-cadence Feb 20, 2024
50 of 51 checks passed
@turbolent turbolent deleted the leo-stable-cadence-util branch February 20, 2024 21:09
@turbolent turbolent changed the title Add osusergo flag Add osusergo flag and missing previewnet case Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants