-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read staged contracts from CSV file #5425
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5425 +/- ##
==========================================================
+ Coverage 56.36% 56.38% +0.01%
==========================================================
Files 1030 1030
Lines 100004 100049 +45
==========================================================
+ Hits 56371 56412 +41
- Misses 39377 39380 +3
- Partials 4256 4257 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a3766bf
to
5a73d83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are new line characters handled in the contract code? It looks like there shouldn't be any.
@janezpodhostnik I'm fairly sure Go's CSV reader supports newlines (escaped; similar to e.g. also commas and quotes), but we can add a test case if needed |
multiline codes can be within quotes: 3778fcd. AFAIK, all CSV writers automatically quote (and escape existing quotes), if string content is multi-lined. |
890a62e
to
3778fcd
Compare
The failing test |
Closes onflow/cadence#3050