[Flow EVM] Improving evm integration tests #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5431 +/- ##
==========================================
+ Coverage 55.30% 55.85% +0.55%
==========================================
Files 946 1029 +83
Lines 96206 100783 +4577
==========================================
+ Hits 53204 56292 +3088
- Misses 38877 40159 +1282
- Partials 4125 4332 +207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
changed the title
ramtinms
changed the title
…m:onflow/flow-go into ramtin/5228-improve-evm-integration-tests
m-Peter
reviewed
Feb 29, 2024
| code: [], | ||
| gasLimit: 53000, | ||
| value: EVM.Balance(attoflow: 1230000000000000000) | ||
| let bal = EVM.Balance(0) |
There was a problem hiding this comment.
Suggested change
| let bal = EVM.Balance(0) | |
| let bal = EVM.Balance(attoflow: 0) |
There was a problem hiding this comment.
This is a breaking change in Cadence 1.0. The named attribute is always required.
m-Peter
reviewed
Feb 29, 2024
| let cadenceOwnedAccount <- EVM.createCadenceOwnedAccount() | ||
| cadenceOwnedAccount.deposit(from: <-vault) | ||
|
|
||
| let bal = EVM.Balance(0) |
There was a problem hiding this comment.
Suggested change
| let bal = EVM.Balance(0) | |
| let bal = EVM.Balance(attoflow: 0) |
m-Peter
reviewed
Feb 29, 2024
| ) uint64 { | ||
| code := []byte(fmt.Sprintf( | ||
| ` | ||
| pub fun main(): UFix64 { |
There was a problem hiding this comment.
Suggested change
| pub fun main(): UFix64 { | |
| access(all) fun main(): UFix64 { |
m-Peter
approved these changes
Feb 29, 2024
sideninja
reviewed
Mar 5, 2024
|
|
||
| assert(res.status == EVM.Status.failed, message: "unexpected status") | ||
| // ExecutionErrCodeExecutionReverted | ||
| assert(res.errorCode == 306, message: "unexpected error code") |
There was a problem hiding this comment.
maybe:
Suggested change
| assert(res.errorCode == 306, message: "unexpected error code") | |
| assert(res.errorCode == %d, message: "unexpected error code") | |
| // ... | |
| types.ExecutionErrCodeExecutionReverted |
sideninja
reviewed
Mar 5, 2024
|
|
||
| let bal = EVM.Balance(0) | ||
| bal.setFLOW(flow: 1.23) | ||
| let vault2 <- cadenceOwnedAccount.withdraw(balance: bal) |
There was a problem hiding this comment.
nit: maybe you can add a line in Cadence that asserts the coa balance is 2.34-1.23.
janezpodhostnik
approved these changes
Mar 5, 2024
|
I'll apply suggested these in my other PR #5443 |
|
applied fixes to 7ae2c70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5228
It also adds some utility methods for integration testing that can be used later to expand the integration tests.