Add DefaultFVMOptions to verification builder #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that it also affects VNs. We should clean this up to avoid similar mistakes in the future. See issue: #5249
sideninja
approved these changes
Feb 22, 2024
ramtinms
approved these changes
Feb 22, 2024
turbolent
reviewed
Feb 22, 2024
| @@ -240,7 +240,6 @@ func DefaultFVMOptions(chainID flow.ChainID, cadenceTracing bool, extensiveTraci | |||
| AttachmentsEnabled: chainID != flow.Mainnet, | |||
| }, | |||
| )), | |||
| fvm.WithEVMEnabled(true), | |||
There was a problem hiding this comment.
Looking at the option above, does that mean that attachments are currently broken on VNs too?
There was a problem hiding this comment.
ah, good catch.... yes.
let me address that.
|
Should this target |
|
I assume we are going to merge the two together soon rigth? Since we are deploying from here I thought I would just put it here. @j1010001 |
janezpodhostnik
changed the title
turbolent
approved these changes
Feb 22, 2024
|
master PR #5440 |
sideninja
approved these changes
Feb 22, 2024
janezpodhostnik
merged commit f6d50be
into
feature/stable-cadence
50 of 51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that VNs have the same context as ENs.
We should clean this up to avoid similar mistakes in the future. See issue: #5249