Herostore message entity nonce #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reenable silence period registry tests
yhassanzadeh13
approved these changes
Feb 23, 2024
| @@ -165,7 +165,8 @@ func NewGossipSubAppSpecificScoreRegistry(config *GossipSubAppSpecificScoreRegis | |||
|
|
|||
| invalidCtrlMsgNotificationStore := queue.NewHeroStore(config.Parameters.InvalidControlMessageNotificationQueueSize, | |||
| lg.With().Str("component", "invalid_control_message_notification_queue").Logger(), | |||
| metrics.RpcInspectorNotificationQueueMetricFactory(config.HeroCacheMetricsFactory, config.NetworkingType)) | |||
| metrics.RpcInspectorNotificationQueueMetricFactory(config.HeroCacheMetricsFactory, config.NetworkingType), | |||
| queue.WithMessageEntityFactory(queue.NewMessageEntityWithNonce)) | |||
peterargue
reviewed
Feb 23, 2024
| Nonce string | ||
| }{ | ||
| msg, | ||
| time.Now().String(), |
There was a problem hiding this comment.
what do you think about using Nonce int64, and then?
Suggested change
| time.Now().String(), | |
| time.Now().UnixNano(), |
it would be 8 bytes instead of 51 (2024-02-23 14:54:13.540848 -0800 PST m=+0.000076126)
There was a problem hiding this comment.
We need to convert it to a string for the RLP encoding e8187bc results in a 19 byte string
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5452 +/- ##
==========================================
+ Coverage 56.01% 57.45% +1.44%
==========================================
Files 1029 850 -179
Lines 100484 84915 -15569
==========================================
- Hits 56287 48791 -7496
+ Misses 39864 32298 -7566
+ Partials 4333 3826 -507
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…flow/flow-go into khalil/herostore-message-entity-nonce
jordanschalm
approved these changes
Feb 29, 2024
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
…flow/flow-go into khalil/herostore-message-entity-nonce
peterargue
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configurable message entity factory function for herostore, allowing users to incorporate a nonce into the message entity. Previously, certain tests utilizing herostore were failing due to unexpected deduplication of messages. These modifications effectively address the issue by providing users with the flexibility to add a nonce, ensuring more predictable and reliable behavior in scenarios involving message deduplication.
ref: https://github.com/dapperlabs/flow-internal/issues/1910