Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] - fix empty tx hash bug for some transactions #5455

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ramtinms
Copy link
Contributor

Port of #5454

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.08%. Comparing base (b295bd5) to head (c77d2a1).

Files Patch % Lines
fvm/evm/types/call.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5455      +/-   ##
==========================================================
- Coverage                   56.38%   56.08%   -0.30%     
==========================================================
  Files                        1032      891     -141     
  Lines                      100604    88886   -11718     
==========================================================
- Hits                        56721    49852    -6869     
+ Misses                      39578    35187    -4391     
+ Partials                     4305     3847     -458     
Flag Coverage Δ
unittests 56.08% <57.14%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sideninja sideninja merged commit 0776bdc into feature/stable-cadence Feb 26, 2024
50 of 51 checks passed
@sideninja sideninja deleted the ramtin/port-of-5454 branch February 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants