Remove db close in execution state sync tests #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
requested review from
durkmurder,
janezpodhostnik,
sideninja and
peterargue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5465 +/- ##
==========================================
+ Coverage 56.04% 57.50% +1.46%
==========================================
Files 1026 848 -178
Lines 100134 84589 -15545
==========================================
- Hits 56118 48643 -7475
+ Misses 39712 32154 -7558
+ Partials 4304 3792 -512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Feb 27, 2024
janezpodhostnik
approved these changes
Feb 28, 2024
zhangchiqing
force-pushed
the
leo/fix-execution-state-sync-tests
branch
from
9e1cd9c to
b1d1af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DB is closed and deleted by
Cleanupmethod duringTearDownTestcall.Calling DB.Close again would try to remove the lock or db folder which has already removed. This sometimes causing an endless loop because when badger can't find the files to delete, it will run a loop to try deleting them, and end up causing the tests to run longer and hit timeout eventually.