Optimize deployment migration #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5470 +/- ##
==========================================================
- Coverage 56.37% 52.63% -3.74%
==========================================================
Files 1032 302 -730
Lines 100648 23473 -77175
==========================================================
- Hits 56738 12356 -44382
+ Misses 39602 10278 -29324
+ Partials 4308 839 -3469
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
changed the base branch from
feature/stable-cadence
to
bastian/improve-migration-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards onflow/cadence#3096
Test the deployment migration, on filtered, instead of full payloads.
Ideally we can filter all payloads in
NewTransactionBasedMigrationto just the once needed for the transaction / deployment, and do not have to build a full snapshot (map) of all payloads, which might be intractable.