Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v1.0.0-M9 #5498

Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Mar 4, 2024

Description

Automatically update to:

Note: Hide whitespace changes to see actual API adjustments

@turbolent turbolent requested review from a team March 4, 2024 18:28
@turbolent
Copy link
Member Author

turbolent commented Mar 4, 2024

So weird, TestGetAccountKey/Multiple_keys fails, the order of the fields in the string representation of PublicKey changed? 🤔

@turbolent
Copy link
Member Author

turbolent commented Mar 4, 2024

@SupunS I did a git bisect on the Cadence side, and it seems like the test starts to fail starting with onflow/cadence@07a7f97. No idea yet why those change would somehow influence the iteration order of composite values' fields (atree ordered map keys)

@turbolent
Copy link
Member Author

Given that PublicKey values are just normal composite values, I guess there is no guaranteed order, as the iteration order of atree ordered maps depends on e.g. the seed of the value. I adjusted the test

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 92.18750% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (524be1e) to head (24e14af).

Files Patch % Lines
fvm/evm/stdlib/contract.go 92.18% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5498      +/-   ##
==========================================================
- Coverage                   55.99%   55.35%   -0.64%     
==========================================================
  Files                        1042      998      -44     
  Lines                      101982    96675    -5307     
==========================================================
- Hits                        57100    53514    -3586     
+ Misses                      40529    39064    -1465     
+ Partials                     4353     4097     -256     
Flag Coverage Δ
unittests 55.35% <92.18%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member Author

turbolent commented Mar 4, 2024

Some tests fail, but they also fail on the target (feature) branch, due to #5482. Will merge anyway, we can fix those unrelated tests separately. Already pinged in the linked PR

@turbolent turbolent merged commit 9a2789f into feature/stable-cadence Mar 4, 2024
50 of 51 checks passed
@turbolent turbolent deleted the auto-update-onflow-cadence-v1.0.0-M9 branch March 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants