-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Cadence v1.0.0-M9 #5498
Update to Cadence v1.0.0-M9 #5498
Conversation
… need to be passed
So weird, |
@SupunS I did a git bisect on the Cadence side, and it seems like the test starts to fail starting with onflow/cadence@07a7f97. No idea yet why those change would somehow influence the iteration order of composite values' fields (atree ordered map keys) |
Given that |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5498 +/- ##
==========================================================
- Coverage 55.99% 55.35% -0.64%
==========================================================
Files 1042 998 -44
Lines 101982 96675 -5307
==========================================================
- Hits 57100 53514 -3586
+ Misses 40529 39064 -1465
+ Partials 4353 4097 -256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Some tests fail, but they also fail on the target (feature) branch, due to #5482. Will merge anyway, we can fix those unrelated tests separately. Already pinged in the linked PR |
Description
Automatically update to:
Note: Hide whitespace changes to see actual API adjustments