Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build typo #5525

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix build typo #5525

merged 3 commits into from
Mar 12, 2024

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Mar 7, 2024

Fix typo for a CGO flag when building for non-adx CPUs.

Side change:
Update Makefile in test modules to match the main repo Makefile. This has no functional impact but keeps the code base consistent

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.85%. Comparing base (64ab8d2) to head (ffcb3ae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5525      +/-   ##
==========================================
+ Coverage   55.74%   55.85%   +0.10%     
==========================================
  Files         978     1030      +52     
  Lines       96397   100843    +4446     
==========================================
+ Hits        53737    56321    +2584     
- Misses      38450    40185    +1735     
- Partials     4210     4337     +127     
Flag Coverage Δ
unittests 55.85% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby added the Bugfix label Mar 7, 2024
@tarakby tarakby marked this pull request as ready for review March 7, 2024 22:18
@tarakby tarakby added this pull request to the merge queue Mar 12, 2024
Merged via the queue into master with commit d47a6f5 Mar 12, 2024
55 checks passed
@tarakby tarakby deleted the tarak/fix-build-typo branch March 12, 2024 18:23
@tarakby tarakby restored the tarak/fix-build-typo branch March 13, 2024 22:39
@tarakby tarakby deleted the tarak/fix-build-typo branch March 13, 2024 22:46
@tarakby tarakby mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants