Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] add testnet chainID #5527

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Mar 7, 2024

closes #5459

@ramtinms ramtinms marked this pull request as ready for review March 7, 2024 23:05
@ramtinms ramtinms requested a review from sideninja March 7, 2024 23:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 55.80%. Comparing base (50761d4) to head (27372df).

Files Patch % Lines
fvm/evm/types/chainIDs.go 0.00% 8 Missing ⚠️
fvm/evm/types/emulator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5527      +/-   ##
==========================================
- Coverage   55.82%   55.80%   -0.02%     
==========================================
  Files        1031     1031              
  Lines      100860   100862       +2     
==========================================
- Hits        56302    56290      -12     
- Misses      40229    40239      +10     
- Partials     4329     4333       +4     
Flag Coverage Δ
unittests 55.80% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezpodhostnik
Copy link
Contributor

If we deploy this on top of an existing previewnet state, will that be ok?

@ramtinms
Copy link
Contributor Author

The preview net is still the default one and also set to the same chain ID as before so should be safe.

@ramtinms ramtinms enabled auto-merge March 12, 2024 17:12
@ramtinms ramtinms added this pull request to the merge queue Mar 12, 2024
Merged via the queue into master with commit 87494ce Mar 12, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/5459-add-testnet-chainID branch March 12, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] provide toHexString and fromHexString for evm address
4 participants