[Flow EVM] populate receipt root hash in blocks #5542
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5542 +/- ##
=======================================
Coverage 55.82% 55.83%
=======================================
Files 1031 1031
Lines 100880 100893 +13
=======================================
+ Hits 56321 56338 +17
+ Misses 40230 40223 -7
- Partials 4329 4332 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -22,6 +23,9 @@ type Block struct { | |||
| TotalSupply *big.Int | |||
|
|
|||
| // ReceiptRoot returns the root hash of the receipts emitted in this block | |||
| // Note that this value won't be unique to each block, for example for the | |||
| // case of empty trie of receipts or a single receipt with no logs and failed state | |||
| // the same receipt root would be reported for block. | |||
There was a problem hiding this comment.
When is this relevant? what kind of transactions cause same receipt root? direct calls?
There was a problem hiding this comment.
Since we don't have any state root and based on the definition of the receipt hash its going to use the tx result (failed or not failed) as part of the computation. and for example, if two blocks both have a single transaction with failed status and same gas consumption (no logs, etc). they would reference the same receipt root hash.
closes: #5509