Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import resolving during staged contract updates #5551

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 15, 2024

Fixes part of onflow/cadence#3098 (comment)

The elaborations and the ContractAdditionHandler used for the contract update validator needs to be initialized using all payloads, not just with the payloads of the migrating account.

@SupunS SupunS self-assigned this Mar 15, 2024
@SupunS SupunS added the Bugfix label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 55.93%. Comparing base (00f5b14) to head (722f220).

Files Patch % Lines
...il/ledger/migrations/staged_contracts_migration.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5551      +/-   ##
==========================================================
+ Coverage                   55.87%   55.93%   +0.05%     
==========================================================
  Files                        1049     1049              
  Lines                      103114   103119       +5     
==========================================================
+ Hits                        57618    57676      +58     
+ Misses                      41103    41057      -46     
+ Partials                     4393     4386       -7     
Flag Coverage Δ
unittests 55.93% <88.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! I must have probably broke this at some point unknowingly, so thank you for also adding a test case 👌

@SupunS SupunS force-pushed the supun/fix-import-resolving branch from fb09c0b to 722f220 Compare March 18, 2024 15:28
@SupunS SupunS closed this Mar 18, 2024
@SupunS SupunS reopened this Mar 18, 2024
@SupunS SupunS merged commit 5ebdc01 into feature/stable-cadence Mar 18, 2024
93 of 96 checks passed
@SupunS SupunS deleted the supun/fix-import-resolving branch March 18, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants