Make contract update validation thread safe #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow-go into supun/improve-migrations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5565 +/- ##
==========================================================
+ Coverage 55.80% 58.33% +2.53%
==========================================================
Files 997 945 -52
Lines 98720 90156 -8564
==========================================================
- Hits 55088 52592 -2496
+ Misses 39369 33635 -5734
+ Partials 4263 3929 -334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SupunS
force-pushed
the
supun/improve-migrations
branch
from
7a61f6d to
f48ad4d
Compare
SupunS
changed the title
janezpodhostnik
approved these changes
Mar 21, 2024
j1010001
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression from e3f48d4, where the initialization of the
ContractAdditionHandlerwas moved to theInitmethod.We still need to have it in the
Initmethod, so instead of reverting the change, just make sure the usages ofContractAdditionHandler(i.e: contract update validation) are thread safe.