Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag for ABI-only version of EVM contract #5587

Merged

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Mar 26, 2024

Closes: #5506

Undo all the changes introduced in #5230

// This will allow to quickly disable the ABI-only EVM, in case there's a bug or something.
setupEVMEnabled cadence.Bool
evmAbiOnly cadence.Bool
setupEVMEnabled cadence.Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can be removed too, but that can be done in a different PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That actually needs a more changes to work, as I think the new account for storage does not have keys. I'll leave this for another PR 🙏

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.65%. Comparing base (51a3fb6) to head (f4e4fc7).
Report is 71 commits behind head on master.

Files Patch % Lines
...edger/migrations/change_contract_code_migration.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5587      +/-   ##
==========================================
- Coverage   55.67%   55.65%   -0.02%     
==========================================
  Files        1037     1037              
  Lines      101404   101393      -11     
==========================================
- Hits        56457    56434      -23     
- Misses      40607    40619      +12     
  Partials     4340     4340              
Flag Coverage Δ
unittests 55.65% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-Peter m-Peter force-pushed the remove-feature-flag-evm-abi-only branch from d95792c to c47ff46 Compare March 26, 2024 18:08
@m-Peter m-Peter force-pushed the remove-feature-flag-evm-abi-only branch from c47ff46 to 62726e8 Compare March 27, 2024 09:43
@sideninja sideninja enabled auto-merge March 27, 2024 16:05
auto-merge was automatically disabled March 27, 2024 16:47

Head branch was pushed to by a user without write access

@m-Peter m-Peter force-pushed the remove-feature-flag-evm-abi-only branch from 62726e8 to f4e4fc7 Compare March 27, 2024 16:47
@ramtinms ramtinms enabled auto-merge April 1, 2024 03:33
@ramtinms ramtinms added this pull request to the merge queue Apr 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2024
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Apr 1, 2024
Merged via the queue into onflow:master with commit 9b21bfb Apr 1, 2024
55 checks passed
@m-Peter m-Peter deleted the remove-feature-flag-evm-abi-only branch April 1, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] clean up only ABI smart contract and flags
4 participants