-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove feature flag for ABI-only version of EVM
contract
#5587
Remove feature flag for ABI-only version of EVM
contract
#5587
Conversation
// This will allow to quickly disable the ABI-only EVM, in case there's a bug or something. | ||
setupEVMEnabled cadence.Bool | ||
evmAbiOnly cadence.Bool | ||
setupEVMEnabled cadence.Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one can be removed too, but that can be done in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janezpodhostnik Removed in d95792c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That actually needs a more changes to work, as I think the new account for storage does not have keys. I'll leave this for another PR 🙏
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5587 +/- ##
==========================================
- Coverage 55.67% 55.65% -0.02%
==========================================
Files 1037 1037
Lines 101404 101393 -11
==========================================
- Hits 56457 56434 -23
- Misses 40607 40619 +12
Partials 4340 4340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d95792c
to
c47ff46
Compare
c47ff46
to
62726e8
Compare
Head branch was pushed to by a user without write access
62726e8
to
f4e4fc7
Compare
Closes: #5506
Undo all the changes introduced in #5230