[Cadence 1.0] Optionally check atree storage health before migration

[turbolent]

Work towards onflow/cadence#3192

The atree storage health check after the migration might error because the input was already unhealthy.

Optionally check the health before the migration, and do not error if the output is unhealthy when the input was already unhealthy.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 65.04854% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 57.30%. Comparing base (1b7ecca) to head (902b189).

Files	Patch %	Lines
...util/ledger/migrations/cadence_values_migration.go	37.25%	30 Missing and 2 partials ⚠️
cmd/util/cmd/execution-state-extract/cmd.go	62.50%	2 Missing and 1 partial ⚠️
...execution-state-extract/execution_state_extract.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5591      +/-   ##
==========================================================
+ Coverage                   55.91%   57.30%   +1.39%     
==========================================================
  Files                        1049      817     -232     
  Lines                      103170    83085   -20085     
==========================================================
- Hits                        57686    47614   -10072     
+ Misses                      41096    31726    -9370     
+ Partials                     4388     3745     -643     

Flag	Coverage Δ
unittests	57.30% <65.04%> (+1.39%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fxamacker]

Nice! This feature can be very useful for troubleshooting.

I left some comments. The before-migration storage health check needs to happen before migration.MigrateAccount().

[fxamacker]

LGTM! 👍

[fxamacker]

Nice ! 👍