-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Unify Event streaming endpoint on the execution data gRPC API #5602
[Access] Unify Event streaming endpoint on the execution data gRPC API #5602
Conversation
…Height, SubscribeEventsFromLatest. Created SubscriptionHandler and refactored events and blocks streaming
… to SubscribeHandler state stream api
…handling, updated godoc for tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5602 +/- ##
==========================================
- Coverage 55.66% 55.59% -0.07%
==========================================
Files 1041 1042 +1
Lines 101935 102002 +67
==========================================
- Hits 56741 56708 -33
- Misses 40839 40934 +95
- Partials 4355 4360 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…O-K/flow-go into UlyanaAndrukhiv/event-streaming
…O-K/flow-go into UlyanaAndrukhiv/event-streaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not finished my review, but here's some early feedback. overall I this is looking good so far
@peterargue, thank you for your feedback. I have updated the pull request accordingly. I would greatly appreciate your guidance on how to address the situation where added the 'deprecated' option to the rpc call and utilized this call in tests, as it has now caused the lint process to fail in the integration test with |
does
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few small comments, but otherwise this looks good.
BlockID: b.ID(), | ||
Height: b.Header.Height, | ||
Events: expectedEvents, | ||
BlockTimestamp: b.Header.Timestamp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you include MessageIndex
here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, MessageIndex
tracking has been relocated to the handler
, so it isn't directly accessible here in the backend
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
#5557
Context
In this PR :
implemented separated gRPC calls for event streaming:
SubscribeEventsFromStartBlockID
,SubscribeEventsFromStartHeight
,SubscribeEventsFromLatest
added the
messageIndex
to responses,created new versions of the backend methods,
modified functional and integration tests by covering new endpoints.
As part of this PR:
In this PR, a bug with missing block timestamps in event responses has been fixed (#4911).