Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Clean up blockID argument from deriveTransactionStatus #5619

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #5559

In this PR the unused blockID argument was removed from the deriveTransactionStatus function.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.38%. Comparing base (ad12394) to head (0dc42cf).

Files Patch % Lines
engine/access/rpc/backend/backend_transactions.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5619      +/-   ##
==========================================
- Coverage   55.55%   55.38%   -0.17%     
==========================================
  Files        1043      984      -59     
  Lines      102034    96859    -5175     
==========================================
- Hits        56689    53650    -3039     
+ Misses      40992    39018    -1974     
+ Partials     4353     4191     -162     
Flag Coverage Δ
unittests 55.38% <91.66%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue requested a review from Guitarheroua April 4, 2024 00:31
@peterargue peterargue enabled auto-merge April 23, 2024 15:37
@peterargue peterargue added this pull request to the merge queue Apr 25, 2024
Merged via the queue into onflow:master with commit 83724f7 Apr 25, 2024
55 checks passed
@AndriiDiachuk AndriiDiachuk deleted the deriveTransactionStatus-clean-up-blockID-argument branch May 10, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Clean up blockID argument from deriveTransactionStatus
4 participants