Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add integration tests covering the 3 streaming blocks endpoints #5624

Conversation

UlyanaAndrukhiv
Copy link
Contributor

#5572

Context

In this PR :

  • implemented subscribe blocks, headers and digests endpoints to FlowAccessAPIRouter for ON,
  • added integration test for 3 streaming blocks endpoints,
  • refactored grpc_state_stream_test integration test.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.91%. Comparing base (ad12394) to head (20a99c9).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5624       +/-   ##
===========================================
+ Coverage   55.55%   56.91%    +1.35%     
===========================================
  Files        1043       16     -1027     
  Lines      102034     1230   -100804     
===========================================
- Hits        56689      700    -55989     
+ Misses      40992      490    -40502     
+ Partials     4353       40     -4313     
Flag Coverage Δ
unittests 56.91% <ø> (+1.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UlyanaAndrukhiv UlyanaAndrukhiv marked this pull request as ready for review April 4, 2024 11:17
@Guitarheroua Guitarheroua self-requested a review April 9, 2024 07:53
@Guitarheroua Guitarheroua added this pull request to the merge queue Apr 11, 2024
Merged via the queue into onflow:master with commit 7b9997b Apr 11, 2024
55 checks passed
@Guitarheroua Guitarheroua deleted the UlyanaAndrukhiv/5572-streaming-blocks-integration-test branch April 11, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants