Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export user defined type change checker #5633

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 5, 2024

This needs to be used in the Flow CLI for preliminary staging validation, would be useful to have this exported if there are any changes in the future/elimates code duplication.

re. onflow/flow-cli#1495

@jribbink jribbink requested a review from SupunS April 5, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.89%. Comparing base (2a63347) to head (e56bb1f).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5633      +/-   ##
==========================================================
- Coverage                   57.33%   55.89%   -1.44%     
==========================================================
  Files                         885     1049     +164     
  Lines                       88736   103206   +14470     
==========================================================
+ Hits                        50876    57689    +6813     
- Misses                      33944    41122    +7178     
- Partials                     3916     4395     +479     
Flag Coverage Δ
unittests 55.89% <100.00%> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS requested a review from a team April 5, 2024 15:53
@turbolent turbolent merged commit 39f59b1 into feature/stable-cadence Apr 5, 2024
55 checks passed
@turbolent turbolent deleted the jribbink/export-type-change branch April 5, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants