Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port binstat fix to feature/stable-cadence #5635

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 5, 2024

Relax requirement for elapsed time during binstat init

I am unsure what the status is on #5575, so I just made this PR to cherry-pick the fix from master to feature/stable-cadence, since this causes issues for Windows users trying to use the Flow CLI & the flow-c1 CLI does not have this fix yet.

Relax requirement for elapsed time during binstat init
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.81%. Comparing base (39f59b1) to head (098692f).

Files Patch % Lines
utils/binstat/binstat.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5635      +/-   ##
==========================================================
+ Coverage                   55.78%   55.81%   +0.02%     
==========================================================
  Files                         997      997              
  Lines                       98760    98760              
==========================================================
+ Hits                        55094    55119      +25     
+ Misses                      39400    39376      -24     
+ Partials                     4266     4265       -1     
Flag Coverage Δ
unittests 55.81% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent requested review from a team April 8, 2024 16:16
@turbolent turbolent merged commit f2cd877 into feature/stable-cadence Apr 10, 2024
54 of 55 checks passed
@turbolent turbolent deleted the jribbink/cherry-pick-binstat branch April 10, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants