Fix unsafeTraverse error handling #5661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Apr 12, 2024
state/fork/traversal.go
Outdated
| @@ -107,9 +107,11 @@ func unsafeTraverse(headers storage.Headers, block *flow.Header, visitor onVisit | |||
| return block, nil | |||
| } | |||
|
|
|||
| block, err = headers.ByBlockID(block.ParentID) | |||
| parent, err := headers.ByBlockID(block.ParentID) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to revtrieve block header %x: %w", block.ParentID, err) | |||
There was a problem hiding this comment.
in this case, block could be nil, and causing nil pointer error
zhangchiqing
requested review from
jordanschalm,
AlexHentschel,
janezpodhostnik and
peterargue
zhangchiqing
force-pushed
the
leo/fix-traversal-error-handling
branch
from
8a8a54f to
33a27e4
Compare
zhangchiqing
commented
Apr 12, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("failed to revtrieve block header %x: %w", block.ParentID, err) |
There was a problem hiding this comment.
in this case, block could be nil, and causing nil pointer error
janezpodhostnik
approved these changes
Apr 15, 2024
jordanschalm
approved these changes
Apr 15, 2024
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
zhangchiqing
force-pushed
the
leo/fix-traversal-error-handling
branch
from
0d7d312 to
4860e67
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The a
nilpointer error in the error handling of theunsafeTraversefunction.