Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix util docker build - port to master #5751

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

j1010001
Copy link
Member

port of #5750 to master

@j1010001 j1010001 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into master with commit 976e3ff Apr 22, 2024
55 checks passed
@j1010001 j1010001 deleted the jan/port-fix-util-docker-build branch April 22, 2024 21:00
@tarakby
Copy link
Contributor

tarakby commented Apr 29, 2024

@j1010001 I wanted to confirm the new behaviour is intended: there are two different images related to the new flag osusergo that our scripts build:

  • default images apply the tag osusergo via the docker variable TAGS
  • images we usually call "without-netgo" (used by some node operators), that overwrite TAGS (here for instance), and that disables the flag osusergo.

Is it intended that the "without-netgo" images disable osusergo ?

@turbolent
Copy link
Member

@tarakby We had problems building static binaries that would work on GCP, and adding osusergo fixed the problem. So from what I can tell it should always be added, but am not sure

@tarakby
Copy link
Contributor

tarakby commented Jul 23, 2024

If that's the case then the Dockerfile should be fixed to always hardcode osusergo and avoid it being overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants