[EVM] Remove special EVM type

[sideninja]

Closes: #5414

💔 API Breaking Change

Remove the special event type for evm: evm.BlockExecuted and evm.TransactionExecuted and make them be generic Flow event types: A.{evm contract address}.EVM.TransactionExecuted and A.{evm contract address}.EVM.BlockExecuted.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.71%. Comparing base (f634093) to head (eda4a17).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5791      +/-   ##
==========================================
+ Coverage   55.68%   55.71%   +0.02%     
==========================================
  Files        1094     1094              
  Lines       85622    85605      -17     
==========================================
+ Hits        47681    47693      +12     
+ Misses      33326    33297      -29     
  Partials     4615     4615              

Flag	Coverage Δ
unittests	55.71% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[turbolent]

Could you also please remove the EVM location again from the Go SDK?

[turbolent]

Use common.Location.TypeID() instead. Same below

[sideninja]

Could you also please remove the EVM location again from the Go SDK?

@m-Peter plans to

[turbolent]

@sideninja Maybe forgot to push? There are no new commits

[m-Peter]

@turbolent @sideninja Here is the PR to remove the EVMLocation location from flow-go-sdk: onflow/flow-go-sdk#638
Note that this location was only incorporated into feature/stable-cadence branch.

[m-Peter]

@sideninja There are a couple more files that ideally should be updated:

• https://github.com/onflow/flow-go/blob/master/model/flow/event.go#L18
• https://github.com/onflow/flow-go/blob/master/model/events/parse.go#L28-L35
• https://github.com/onflow/flow-go/blob/master/model/events/parse_test.go#L46-L57

It would also be very useful to address this suggestion as well: #5414 (comment)

We should also include the event definitions in the EVM contract itself, for example:

access(all)
event BlockExecuted(
    height: UInt64,
    hash: String,
    ...
)

access(all)
event TransactionExecuted(
    blockHeight: UInt64,
    blockHash: String,
    hash: String,
    payload: String,
    ...
    logs: String
)

This will be helpful for other tools (such as the Cadence testing framework), to make use of these types cc @turbolent

[sideninja]

@sideninja Maybe forgot to push? There are no new commits

I did, sorry

[sideninja]

@sideninja There are a couple more files that ideally should be updated:

• https://github.com/onflow/flow-go/blob/master/model/flow/event.go#L18
• https://github.com/onflow/flow-go/blob/master/model/events/parse.go#L28-L35
• https://github.com/onflow/flow-go/blob/master/model/events/parse_test.go#L46-L57

It would also be very useful to address this suggestion as well: #5414 (comment)

We should also include the event definitions in the EVM contract itself, for example:

access(all)
event BlockExecuted(
    height: UInt64,
    hash: String,
    ...
)

access(all)
event TransactionExecuted(
    blockHeight: UInt64,
    blockHash: String,
    hash: String,
    payload: String,
    ...
    logs: String
)

This will be helpful for other tools (such as the Cadence testing framework), to make use of these types cc @turbolent

Great feedback, thanks. I like the idea of defining the event in the contract.

[m-Peter]

LGTM! 👌

[turbolent]

Nice!