Improve migration logging, reports, and export broken slabs that were fixed to a new payloads file #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits reduces logging, improves reports, and creates a payload file containing all slabs with broken references (currently only 10 testnet slabs and none on mainnet). Changes include: - log filtered slab count instead of slab IDs to reduce logging - write hex encoded account (instead of raw bytes) in reports - write slabs with broken references to payload file - refactor code
turbolent
approved these changes
Apr 29, 2024
SupunS
approved these changes
Apr 29, 2024
@turbolent I opened PR #5805 to port this to v0.42 + atree inlining branch. PTAL 🙏 |
fxamacker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces logging, improves reports, and creates a payload file containing all slabs with broken references (currently only 10 testnet slabs and none on mainnet).
Changes include: