Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implemented options to fail or warn when payer is not able to pay #6297

Conversation

Guitarheroua
Copy link
Contributor

@Guitarheroua Guitarheroua commented Aug 6, 2024

#6139

Added implementation of PayerBalanceMode to control whether transaction validation should fail or warn when the payer cannot pay.

DEPENDS ON: onflow/flow-emulator#756

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 25.58140% with 32 lines in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (79d1fe6) to head (bc4b885).

Files with missing lines Patch % Lines
access/validator.go 12.00% 20 Missing and 2 partials ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6297      +/-   ##
==========================================
- Coverage   41.29%   41.29%   -0.01%     
==========================================
  Files        2030     2030              
  Lines      145798   145829      +31     
==========================================
+ Hits        60205    60213       +8     
- Misses      79367    79392      +25     
+ Partials     6226     6224       -2     
Flag Coverage Δ
unittests 41.29% <25.58%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua requested a review from peterargue August 6, 2024 12:07
access/validator.go Outdated Show resolved Hide resolved
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please also update the observer

@Guitarheroua Guitarheroua marked this pull request as ready for review September 3, 2024 10:14
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

access/validator.go Show resolved Hide resolved
Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add some godoc which describes how and when it's being used.

integration/go.mod Outdated Show resolved Hide resolved
@peterargue peterargue added this pull request to the merge queue Oct 1, 2024
Merged via the queue into onflow:master with commit ec4ad1c Oct 1, 2024
55 checks passed
@peterargue peterargue deleted the AndriiSlisarchuk/6139-fail-or-warn-tx-balance branch October 1, 2024 14:32
Guitarheroua pushed a commit to The-K-R-O-K/flow-go that referenced this pull request Oct 9, 2024
…-fail-or-warn-tx-balance

[Access] Implemented options to fail or warn when payer is not able to pay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants