-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implemented options to fail or warn when payer is not able to pay #6297
[Access] Implemented options to fail or warn when payer is not able to pay #6297
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6297 +/- ##
==========================================
- Coverage 41.29% 41.29% -0.01%
==========================================
Files 2030 2030
Lines 145798 145829 +31
==========================================
+ Hits 60205 60213 +8
- Misses 79367 79392 +25
+ Partials 6226 6224 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…isarchuk/6139-fail-or-warn-tx-balance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. please also update the observer
…isarchuk/6139-fail-or-warn-tx-balance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please add some godoc which describes how and when it's being used.
…isarchuk/6139-fail-or-warn-tx-balance
…-fail-or-warn-tx-balance [Access] Implemented options to fail or warn when payer is not able to pay
#6139
Added implementation of
PayerBalanceMode
to control whether transaction validation should fail or warn when the payer cannot pay.DEPENDS ON: onflow/flow-emulator#756