Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.37] Lower retry interval in EN requester engine #6436

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Sep 5, 2024

Backport #6444

We have observed execution nodes (in particular Mainnet EN1) occasionally fail to retrieve collections using this engine, which can cause temporary execution halts. Setting a retry maximum of 10s empirically results in a much faster recovery from these faults (default is 2m).

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.07%. Comparing base (17e08c4) to head (9c677e7).
Report is 9 commits behind head on v0.37.

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6436      +/-   ##
==========================================
- Coverage   41.47%   41.07%   -0.41%     
==========================================
  Files        2016     1885     -131     
  Lines      143698   132634   -11064     
==========================================
- Hits        59602    54479    -5123     
+ Misses      77917    72487    -5430     
+ Partials     6179     5668     -511     
Flag Coverage Δ
unittests 41.07% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanschalm jordanschalm changed the title [DRAFT] Lower retry interval in EN requester engine [v0.27] Lower retry interval in EN requester engine Sep 6, 2024
@jordanschalm jordanschalm changed the title [v0.27] Lower retry interval in EN requester engine [v0.37] Lower retry interval in EN requester engine Sep 6, 2024
@jordanschalm jordanschalm marked this pull request as ready for review September 6, 2024 23:26
@jordanschalm jordanschalm merged commit 5916deb into v0.37 Sep 6, 2024
55 checks passed
@jordanschalm jordanschalm deleted the jord/en-fetch-collection-10s-retry branch September 6, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants