Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose sample size logs #6441

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Verbose sample size logs #6441

merged 1 commit into from
Sep 6, 2024

Conversation

kc1116
Copy link
Contributor

@kc1116 kc1116 commented Sep 5, 2024

Currently nodes emit thousands of warning logs when sample size is calculated based on the last highest ihave count received and this sample size exceeds our configured message id threshold count. This log does not necessarily always indicate a suspicious activity as we have seen larger amounts of iWant messages being received compared to the initial default value in the network config. This PR changes the log level from warn to debug, so that these logs can be used as an extra step of debugging when looking into an issue.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (5e2d76f) to head (e515ac6).

Files with missing lines Patch % Lines
...validation/control_message_validation_inspector.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6441   +/-   ##
=======================================
  Coverage   41.42%   41.42%           
=======================================
  Files        2021     2021           
  Lines      143934   143934           
=======================================
+ Hits        59620    59622    +2     
+ Misses      78142    78141    -1     
+ Partials     6172     6171    -1     
Flag Coverage Δ
unittests 41.42% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kc1116 kc1116 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 59a9dc7 Sep 6, 2024
55 checks passed
@kc1116 kc1116 deleted the khalil/sample-size-log branch September 6, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants