Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower retry interval in EN requester engine #6444

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Lower retry interval in EN requester engine #6444

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9150daf
set max retry interval for en requester engine to 10s
jordanschalm Sep 4, 2024
85232ce
add comment explaining settings change
jordanschalm Sep 6, 2024
d640ece
Merge branch 'master' into jord/backport-en-fetch-collection-10s
jordanschalm Sep 6, 2024
ab99023
Merge branch 'master' into jord/backport-en-fetch-collection-10s
jordanschalm Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/execution_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,9 @@ func (exeNode *ExecutionNode) LoadIngestionEngine(
// consistency of collection can be checked by checking hash, and hash comes from trusted source (blocks from consensus follower)
// hence we not need to check origin
requester.WithValidateStaking(false),
// we have observed execution nodes occasionally fail to retrieve collections using this engine, which can cause temporary execution halts
// setting a retry maximum of 10s results in a much faster recovery from these faults (default is 2m)
requester.WithRetryMaximum(10*time.Second),
)

if err != nil {
Expand Down
Loading