Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PR 6430 (Support EVM registers in check-storage) to v0.37 #6454

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Sep 10, 2024

This PR updates check-storage command to decode and check EVM registers by porting PR 6430 to v0.37 branch:

A draft version of this program didn't find any problems with EVM registers before September 4 spork. Same with PR 6430 version after spork.

@fxamacker fxamacker requested a review from a team September 10, 2024 14:54
@fxamacker fxamacker self-assigned this Sep 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 40.54054% with 176 lines in your changes missing coverage. Please review.

Project coverage is 41.49%. Comparing base (5916deb) to head (452a99f).

Files with missing lines Patch % Lines
...il/cmd/check-storage/evm_account_storage_health.go 41.37% 145 Missing and 25 partials ⚠️
cmd/util/cmd/check-storage/cmd.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6454      +/-   ##
==========================================
+ Coverage   41.47%   41.49%   +0.01%     
==========================================
  Files        2016     2017       +1     
  Lines      143706   143993     +287     
==========================================
+ Hits        59607    59751     +144     
- Misses      77921    78036     +115     
- Partials     6178     6206      +28     
Flag Coverage Δ
unittests 41.49% <40.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fxamacker
Copy link
Member Author

@ramtinms PTAL 🙏

@fxamacker fxamacker requested a review from ramtinms September 10, 2024 15:44
@fxamacker fxamacker merged commit 0cd570f into v0.37 Sep 10, 2024
55 checks passed
@fxamacker fxamacker deleted the fxamacker/port-6430 branch September 10, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants