Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] port of #6451 - Adding commitment over state update #6476

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Sep 18, 2024

port of #6451

@ramtinms ramtinms changed the title [EVM] port of #6451 Adding commitment over state update [EVM] port of #6451 - Adding commitment over state update Sep 18, 2024
@ramtinms ramtinms marked this pull request as ready for review September 18, 2024 18:04
@ramtinms ramtinms requested review from sideninja and zhangchiqing and removed request for janezpodhostnik September 18, 2024 18:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 41.53%. Comparing base (5be1172) to head (7691d3b).

Files with missing lines Patch % Lines
fvm/evm/emulator/state/stateDB.go 52.63% 15 Missing and 3 partials ⚠️
fvm/evm/emulator/emulator.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6476      +/-   ##
==========================================
+ Coverage   41.51%   41.53%   +0.02%     
==========================================
  Files        2017     2018       +1     
  Lines      144007   144089      +82     
==========================================
+ Hits        59778    59846      +68     
- Misses      78028    78036       +8     
- Partials     6201     6207       +6     
Flag Coverage Δ
unittests 41.53% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms changed the title [EVM] port of #6451 - Adding commitment over state update [Do not merge] [EVM] port of #6451 - Adding commitment over state update Sep 18, 2024
@ramtinms ramtinms marked this pull request as draft September 18, 2024 20:38
@ramtinms ramtinms marked this pull request as ready for review October 3, 2024 19:59
@ramtinms ramtinms changed the title [Do not merge] [EVM] port of #6451 - Adding commitment over state update [EVM] port of #6451 - Adding commitment over state update Oct 3, 2024
@ramtinms ramtinms requested review from janezpodhostnik and j1010001 and removed request for sideninja October 3, 2024 19:59
@ramtinms ramtinms requested a review from turbolent October 3, 2024 21:24
@turbolent turbolent merged commit 8e3b4eb into v0.37 Oct 3, 2024
54 of 55 checks passed
@turbolent turbolent deleted the ramtin/port-6451 branch October 3, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants