Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] port of 6456 - add state update checksum to tx executed events #6477

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Sep 18, 2024

port of #6456

@ramtinms ramtinms changed the base branch from v0.37 to ramtin/port-6451 September 18, 2024 18:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 42 lines in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (8e3b4eb) to head (0580f21).

Files with missing lines Patch % Lines
fvm/evm/events/events.go 13.04% 38 Missing and 2 partials ⚠️
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6477      +/-   ##
==========================================
- Coverage   41.50%   41.29%   -0.22%     
==========================================
  Files        1836     2021     +185     
  Lines      135673   145062    +9389     
==========================================
+ Hits        56316    59899    +3583     
- Misses      73419    78934    +5515     
- Partials     5938     6229     +291     
Flag Coverage Δ
unittests 41.29% <22.22%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms changed the title [EVM] port of 6456 - add state update checksum to tx executed events [Do not merge] [EVM] port of 6456 - add state update checksum to tx executed events Sep 18, 2024
@ramtinms ramtinms requested a review from zhangchiqing October 3, 2024 20:00
@ramtinms ramtinms changed the title [Do not merge] [EVM] port of 6456 - add state update checksum to tx executed events [EVM] port of 6456 - add state update checksum to tx executed events Oct 3, 2024
@ramtinms ramtinms marked this pull request as ready for review October 3, 2024 20:00
@ramtinms ramtinms requested a review from turbolent October 3, 2024 21:23
Base automatically changed from ramtin/port-6451 to v0.37 October 3, 2024 23:16
An error occurred while trying to automatically change base from ramtin/port-6451 to v0.37 October 3, 2024 23:16
@turbolent turbolent merged commit f3b9003 into v0.37 Oct 3, 2024
55 checks passed
@turbolent turbolent deleted the ramtin/port-6456 branch October 3, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants