Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose version boundary to cadence interface - port #6597

Merged
merged 14 commits into from
Oct 25, 2024

Conversation

janezpodhostnik
Copy link
Contributor

port of #6560

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 51.80723% with 120 lines in your changes missing coverage. Please review.

Project coverage is 41.59%. Comparing base (1c2acbd) to head (03025cb).

Files with missing lines Patch % Lines
...vironment/mock/minimum_cadence_required_version.go 0.00% 27 Missing ⚠️
model/convert/service_event.go 55.93% 20 Missing and 6 partials ⚠️
fvm/environment/mock/environment.go 0.00% 22 Missing ⚠️
fvm/executionParameters.go 68.33% 15 Missing and 4 partials ⚠️
fvm/environment/minimum_required_version.go 57.14% 9 Missing ⚠️
fvm/storage/derived/derived_block_data.go 33.33% 6 Missing ⚠️
fvm/context.go 0.00% 5 Missing ⚠️
fvm/transactionInvoker.go 70.00% 2 Missing and 1 partial ⚠️
fvm/storage/state/transaction_state.go 0.00% 2 Missing ⚠️
module/state_synchronization/indexer/util.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            v0.37    #6597    +/-   ##
========================================
  Coverage   41.59%   41.59%            
========================================
  Files        2021     2023     +2     
  Lines      180509   180652   +143     
========================================
+ Hits        75076    75150    +74     
- Misses      99202    99271    +69     
  Partials     6231     6231            
Flag Coverage Δ
unittests 41.59% <51.80%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1010001 j1010001 self-requested a review October 25, 2024 20:26
@j1010001 j1010001 merged commit cc866e6 into v0.37 Oct 25, 2024
55 checks passed
@j1010001 j1010001 deleted the janez/version-boundary-to-cadence-port branch October 25, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants