Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues where time-to-seal was NaN #6625

Merged

Conversation

AndriiDiachuk
Copy link
Contributor

The new time_to_seal metric was reporting NaN for values. Fixed this issue.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (9ac49af) to head (be92cbf).

Files with missing lines Patch % Lines
module/metrics/transaction.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6625      +/-   ##
==========================================
+ Coverage   41.56%   41.81%   +0.25%     
==========================================
  Files        2023     1584     -439     
  Lines      180764   148796   -31968     
==========================================
- Hits        75130    62216   -12914     
+ Misses      99398    81520   -17878     
+ Partials     6236     5060    -1176     
Flag Coverage Δ
unittests 41.81% <0.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-requested a review November 8, 2024 16:18
Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalchangrani vishalchangrani merged commit 4162017 into onflow:v0.37 Nov 8, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants