-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for private registry builds #6742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6742 +/- ##
==========================================
- Coverage 40.98% 40.97% -0.02%
==========================================
Files 2079 2079
Lines 183922 183922
==========================================
- Hits 75389 75366 -23
- Misses 102232 102253 +21
- Partials 6301 6303 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 20, 2024 16:10 — with
GitHub Actions
Failure
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 20, 2024 16:20 — with
GitHub Actions
Failure
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 20, 2024 16:30 — with
GitHub Actions
Failure
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 20, 2024 20:20 — with
GitHub Actions
Failure
sjonpaulbrown
temporarily deployed
to
Production Docker Registry
November 20, 2024 20:21 — with
GitHub Actions
Inactive
sjonpaulbrown
force-pushed
the
jp/support-private-registry
branch
from
November 20, 2024 23:51
9846741
to
58c8ab8
Compare
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 20, 2024 23:58 — with
GitHub Actions
Failure
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 20, 2024 23:58 — with
GitHub Actions
Failure
sjonpaulbrown
force-pushed
the
jp/support-private-registry
branch
from
November 21, 2024 00:04
58c8ab8
to
2ba50ed
Compare
sjonpaulbrown
temporarily deployed
to
Production Docker Registry
November 21, 2024 00:16 — with
GitHub Actions
Inactive
sjonpaulbrown
temporarily deployed
to
Production Docker Registry
November 21, 2024 00:22 — with
GitHub Actions
Inactive
sjonpaulbrown
had a problem deploying
to
Production Docker Registry
November 21, 2024 00:22 — with
GitHub Actions
Error
Kay-Zee
approved these changes
Nov 21, 2024
peterargue
approved these changes
Nov 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Support for Private Registry Builds
This PR introduces support for building and pushing Docker images to a private registry. The changes include:
New Input
private_build
:private_build
has been added to the workflow.Enhanced Google Cloud Authentication:
gcloud auth configure-docker
logic to conditionally authenticate with the private registry (us-central1-docker.pkg.dev
) whenprivate_build
is set to true. Defaults to public registry otherwise.Container Registry Variable Setup:
CONTAINER_REGISTRY
environment variable.PRIVATE_REGISTRY
andPUBLIC_REGISTRY
based on the value of theprivate_build
input.Build/Push Commands:
make
commands to reference theCONTAINER_REGISTRY
environment variable.Improved Workflow Modularity:
Use Case:
This enhancement is designed to support scenarios where private Docker image builds are required, such as deploying hotfixes or managing private image distributions. It maintains compatibility with existing public registry workflows while adding flexibility for private builds.
Example Workflow Executions