-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus] Repopulating of assignment collectors tree #765
Merged
durkmurder
merged 10 commits into
yurii/5417-approval-processing-engine
from
yurii/5216-repopulate-assignment-collector-tree
Jun 3, 2021
Merged
[Consensus] Repopulating of assignment collectors tree #765
durkmurder
merged 10 commits into
yurii/5417-approval-processing-engine
from
yurii/5216-repopulate-assignment-collector-tree
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/onflow/flow-go into yurii/5216-repopulate-assignment-collector-tree
…. Updated tests. Updated godoc.
zhangchiqing
approved these changes
May 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me 👍
…b.com/onflow/flow-go into yurii/5216-repopulate-assignment-collector-tree
…b.com/onflow/flow-go into yurii/5216-repopulate-assignment-collector-tree
…b.com/onflow/flow-go into yurii/5216-repopulate-assignment-collector-tree
…b.com/onflow/flow-go into yurii/5216-repopulate-assignment-collector-tree
…b.com/onflow/flow-go into yurii/5216-repopulate-assignment-collector-tree
AlexHentschel
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, well-documented code.
Only made a few stylistic suggestions. Please use whatever you like better.
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dapperlabs/flow-go/issues/5216
This PR implements repopulating of assignment collectors tree.
Issue description is a bit outdated, based on new architecture of
sealing.Core
it's now implemented as part of core and repopulates collectors tree instead ofIncorporatedResults
mempool.