Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consensus] Repopulating of assignment collectors tree #765

Conversation

durkmurder
Copy link
Member

dapperlabs/flow-go/issues/5216

This PR implements repopulating of assignment collectors tree.
Issue description is a bit outdated, based on new architecture of sealing.Core it's now implemented as part of core and repopulates collectors tree instead of IncorporatedResults mempool.

Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me 👍

engine/consensus/sealing/core.go Show resolved Hide resolved
engine/consensus/sealing/core.go Outdated Show resolved Hide resolved
Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, well-documented code.
Only made a few stylistic suggestions. Please use whatever you like better.

engine/consensus/sealing/core.go Outdated Show resolved Hide resolved
engine/consensus/sealing/core.go Outdated Show resolved Hide resolved
engine/consensus/sealing/core.go Outdated Show resolved Hide resolved
engine/consensus/sealing/core.go Outdated Show resolved Hide resolved
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
@durkmurder durkmurder merged commit e39ec83 into yurii/5417-approval-processing-engine Jun 3, 2021
@durkmurder durkmurder deleted the yurii/5216-repopulate-assignment-collector-tree branch June 3, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants