[Access] Add API that return node information such as version, commit, spork Id and protocol version. #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-version-of-protocol
…t-version-of-protocol
Guitarheroua
changed the title
peterargue
approved these changes
Apr 24, 2023
…t-version-of-protocol
|
@Guitarheroua can you address those conflicts? they're just from merging your other PR |
…t-version-of-protocol
…protocol' of github.com:Guitarheroua/flow into guitarheroua/2134-add-api-to-return-current-version-of-protocol
…t-version-of-protocol
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Apr 28, 2023
4235: [Access] Add API that return node information such as version, commit, spork Id and protocol version. r=peterargue a=Guitarheroua #2134 ### Context This pull request adds a new API query `GetNodeVersionInfo` for RPC/REST that returns essential node information, including version number, commit hash, spork ID, and protocol version. As part of this PR: * The protobuf/openapi structures have been extended (see onflow/flow#1332) * Tests for the new API have been added for RPC/REST. NOTE: The Cadence version is still under discussion. See #2134 (comment) Co-authored-by: Andriy Slisarchuk <andriyslisarchuk@gmail.com> Co-authored-by: Andrii Slisarchuk <andriyslisarchuk@gmail.com> Co-authored-by: Andrii Slisarchuk <Guitarheroua@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onflow/flow-go#2134
Description
I have added a new request/response for the node version information API query in GRPC protobuf. Additionally, I have extended the OpenAPI model for REST with a new endpoint for node version information.