Add ccf indicator flag to grpc #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koko1123
requested review from
zhangchiqing,
fxamacker,
janezpodhostnik and
sideninja
| @@ -105,6 +105,7 @@ message GetEventsForBlockIDsResponse { | |||
| repeated entities.Event events = 3; | |||
| } | |||
| repeated Result results = 1; | |||
| bool is_ccf = 2; | |||
There was a problem hiding this comment.
does it make sense to instead use a more generic: eventEncodingVersion
There was a problem hiding this comment.
Great suggestion Janez! 👍
It would be helpful if eventEncodingVersion identifies the combination of encoding format + format version. E.g. if it's an enum then members like:
- JSON_CDC_V0
- ...
- CCF_V0
| @@ -14,7 +14,8 @@ message BlockHeader { | |||
| google.protobuf.Timestamp timestamp = 4; | |||
| bytes payload_hash = 5; | |||
| uint64 view = 6; | |||
| repeated bytes parent_voter_ids = 7; // deprecated!! value will be empty. replaced by parent_vote_indices | |||
| repeated bytes parent_voter_ids = | |||
There was a problem hiding this comment.
this is some really weird formatting. Is this ok?
There was a problem hiding this comment.
this is auto from make format, I'll undo this for pragmatism
janezpodhostnik
approved these changes
Jun 1, 2023
fxamacker
approved these changes
Jun 1, 2023
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates flag for ccf endcoding
remaining changes are from
make formatfixes #2283