Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firstset node to NO list #1506

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Add Firstset node to NO list #1506

merged 1 commit into from
Sep 12, 2024

Conversation

bernatfp
Copy link
Contributor

Description

Discussed with @vishalchangrani that we would add our node to the NO list.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@bernatfp
Copy link
Contributor Author

thanks @franklywatson - anything missing to get it merged?

@franklywatson franklywatson merged commit fe521d6 into onflow:master Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklywatson franklywatson franklywatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernatfp @franklywatson