Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptography terms improvement #742

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Cryptography terms improvement #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions flips/20201125-bip-44-multi-account.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,7 @@ m / 44' / 1' / 769 / 0 / 0
```

All keys generated with the legacy path as of today (Dec 2021) have been done so using the
ECDSA P256<sup>1</sup> curve.

<sup>1</sup>ECDSA P256 is Elliptic Curve Digital Signature Algorithm (ECDSA) on
the NIST P-256 curve.
NIST P-256 elliptic curve.

### Account Discovery

Expand All @@ -141,19 +138,19 @@ The account index gap limit should be `5`.

The prescribed account discovery procedure is as follows:

1. Derive the key pair using the legacy path and ECDSA P256<sup>1</sup>,
1. Derive the key pair using the legacy path and P-256 curve,
checking its use with the public key registry. If an address is found,
query the Flow network to fetch the account's details. If an account
is found, remember the relationship between the path used to generate
this key and the account's details.
2. Derive the key pair(s) (starting with account index = 0 and key index = 0)
using the path specified in this FLIP and each elliptic curve that
both you and Flow support (Flow currently supports keys generated on the
ECDSA P256<sup>1</sup> and ECDSA secp256k1<sup>2</sup> curves).
P-256 and secp256k1 curves).
Note: If you are unable to derive keys for a certain elliptic curve,
you may fail to discover an account / key that the user has generated
previously.
1. Scan for each keys usage by querying the public key registry with the key and
3. Scan for each keys usage by querying the public key registry with the key and
elliptic curve used to generate it.
If the gap limit has been reached for both key index and account index, stop
discovery.
Expand All @@ -165,20 +162,14 @@ The prescribed account discovery procedure is as follows:
increment the key index by one.
- 3.2. If one or more addresses are found, query the Flow network to fetch each
account's details.
- 3.2.1. If no accounts are found<sup>3</sup>, go to step 2, incrementing
- 3.2.1. If no accounts are found<sup>1</sup>, go to step 2, incrementing
the account index by one.
- 3.2.2. For each account found<sup>3</sup>, remember the relationship between the path
- 3.2.2. For each account found<sup>1</sup>, remember the relationship between the path
used to generate this key, the curve used to generate this key,
and the hash algorithm corresponding to this key and the account's details.
Then go to step 2, incrementing the key index by one.

<sup>1</sup>ECDSA P256 is Elliptic Curve Digital Signature Algorithm (ECDSA) on
the NIST P-256 curve.

<sup>2</sup>ECDSA secp256k1 is Elliptic Curve Digital Signature Algorithm (ECDSA) on
the secp256k1 curve.

<sup>3</sup>Flow supports account deletion, meaning that an address found in the
<sup>1</sup>Flow supports account deletion, meaning that an address found in the
registry may refer to a nonexistent account. In this case the address should be
skipped but discovery should continue.

Expand Down