Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Fix unable to open a new file via CLI #2683

Merged
merged 2 commits into from Dec 15, 2018
Merged

Fix unable to open a new file via CLI #2683

merged 2 commits into from Dec 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2018

See commit message for more information.

Made a minor change to browser/src/App.ts to only filter files if they
exists and pass them through otherwise.
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #2683 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
- Coverage   45.78%   45.77%   -0.01%     
==========================================
  Files         361      361              
  Lines       14634    14637       +3     
  Branches     1926     1927       +1     
==========================================
  Hits         6700     6700              
- Misses       7703     7706       +3     
  Partials      231      231
Impacted Files Coverage Δ
browser/src/App.ts 8.88% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6128e77...f00b6ea. Read the comment docs.

@bryphe
Copy link
Member

bryphe commented Dec 15, 2018

Thanks for the fix, @samvv ! I think this fixes an issue I have occasionally - I'll run oni someNewFile.md and it won't actually be created. Looks good to me! 👍

@bryphe bryphe merged commit d66d786 into onivim:master Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants