Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table rendering when table has background style property instead … #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix table rendering when table has background style property instead … #30

wants to merge 1 commit into from

Conversation

advapiIT
Copy link

@advapiIT advapiIT commented Apr 4, 2018

…of background-color

Updated project to VS 2017

@onizet
Copy link
Owner

onizet commented Jul 14, 2018

Hello @advapiIT,
sorry for late reply! I quite agree with your fix however, I would prefer a real parsing of "background" because your implementation is a bit naive and will not parse more elaborate style.
See https://www.w3schools.com/css/css_background.asp for sample.

Other remarks, if you do a PR, please include only the file that should be updated, and not the csproj, sln and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@advapiIT @onizet