Skip to content

Commit

Permalink
reverted to using round even wiht emulation do to a mac os issue
Browse files Browse the repository at this point in the history
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
  • Loading branch information
AlexandreEichenberger committed Oct 9, 2024
1 parent 23031aa commit 3977369
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/Dialect/Krnl/DialectBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,9 @@ Value KrnlBuilder::roundEven(Value input) const {
}
// No need for custom support, use math roundEven. May want to evaluate
// whether to use the mlir roundEven or our own emulation.
return create.math.roundEven(input);
// Note: MacOS CI has an issue with the roundEven instruction, thus continue
// to use emulation. May change in the future.
return create.math.roundEvenEmulation(input);
}

//===----------------------------------------------------------------------===//
Expand Down

0 comments on commit 3977369

Please sign in to comment.