Exec session updates #1173
Merged
Exec session updates #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
etiotto
approved these changes
Feb 10, 2022
| ExecutionSession::run( | ||
| std::vector<std::unique_ptr<OMTensor, decltype(&omTensorDestroy)>> ins) { | ||
| std::vector<OMTensorUniquePtr> ExecutionSession::run( | ||
| std::vector<OMTensorUniquePtr> ins) { |
There was a problem hiding this comment.
I like the name OMTensorUniquePtr, will use it as well.
There was a problem hiding this comment.
I changed it in your recent code as well.
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@etiotto recently introduce an alias for
unique_ptr<OMTensor, decltype(&omTensorDestroy)>, and I used (a slightly renamed version of it) everywhere in the code.Also, our execution session was only supporting vectors of unique ptr of OMTensor, but not the native OMTensorList. I added a function to also support this.
This PR is short, a larger discussion is whether we should add also a C interface in our runtime for execution session, which essentially does dynamic linking of our entry points.