Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ScatterOp to ScatterElementsOp #1337

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

etiotto
Copy link
Collaborator

@etiotto etiotto commented Apr 12, 2022

This PR rewrites the deprecated ONNX Scatter operation ((https://github.com/onnx/onnx/blob/main/docs/Operators.md#Scatter) using the equivalent ScatterElements operation.

Signed-off-by: Ettore Tiotto etiotto@ca.ibm.com

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>
@etiotto etiotto self-assigned this Apr 12, 2022
Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@etiotto etiotto merged commit fa66317 into onnx:main Apr 13, 2022
@etiotto etiotto deleted the ScatterToScatteElements branch April 13, 2022 13:46
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #5092 [push] Rewrite ScatterOp to Sca... started at 09:47

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #4213 [push] Rewrite ScatterOp to Sca... started at 09:50

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #5076 [push] Rewrite ScatterOp to Sca... started at 08:47

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #5092 [push] Rewrite ScatterOp to Sca... passed after 50 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #4213 [push] Rewrite ScatterOp to Sca... passed after 1 hr 1 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #5076 [push] Rewrite ScatterOp to Sca... passed after 1 hr 2 min

@etiotto etiotto mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants